Skip to content

[Fix] Base Attack Context Menu#1961

Merged
WBHarry merged 5 commits into
mainfrom
fix/base-attack-context-menu
Jun 1, 2026
Merged

[Fix] Base Attack Context Menu#1961
WBHarry merged 5 commits into
mainfrom
fix/base-attack-context-menu

Conversation

@WBHarry

@WBHarry WBHarry commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Fixes #1924
Fixes #1669

  • Fixed Adversary standard attack context menu
  • Fixed Character base attack context menu
  • Fixed Companion base attack context menu

I only added in attack/damage/show-message as these are not things to edit or delete. The main benefit is the Damage option being available now.
image

Minor thing I also spotted - fixed so that adversaries do not display Object Object if the current Attack Damage is invalid
Previous
image

After
image

@CarlosFdez

CarlosFdez commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

If the options are the same everywhere, protected method or actor folder helpers? The copy paste is fine now but if extended/fixed it'd be nice to avoid a desync.

@WBHarry

WBHarry commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

Hm, yah they are strict al-dente copy pastas. Hm hm..

@WBHarry

WBHarry commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

So I can easily just define a static method in the parent that all 3 of 'em use:

contextMenus: [
    {
        handler: DHBaseActorSheet.getBaseAttackContextOptions,
        selector: '[data-item-uuid][data-type="attack"]',
        options: {
            parentClassHooks: false,
            fixed: true
        }
    }
]

Dunno if I can really make it protected though, since it has to be statically available for static DEFAULT_OPTIONS 🤔

@CarlosFdez

CarlosFdez commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

That should be fine.

@WBHarry WBHarry merged commit 3c36c57 into main Jun 1, 2026
1 check passed
@WBHarry WBHarry deleted the fix/base-attack-context-menu branch June 1, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Right-Click on Adversary Attack is unresponsive [Bug] unarmed options not appearing

2 participants